Merge pull request #156 from UKHomeOffice/error-status

Send correct method not supported error and status
HMPO · Jul 15, 2020 · e633808 · e633808
2 parents 3d44ce1 + 1568f0a
commit e633808
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/controller/index.js b/lib/controller/index.js
@@ -103,7 +103,8 @@ class BaseController {
     methodNotSupported(req, res, next) {
         debug('%s #methodNotSupported', req.originalUrl);
         let err = new Error('Method not supported');
-        err.statusCode = 405;
+        err.code = 'METHOD_NOT_SUPPORTED';
+        err.status = 405;
         next(err);
     }
 

diff --git a/test/controller/spec.index.js b/test/controller/spec.index.js
@@ -428,7 +428,8 @@ describe('Form Controller', () => {
             controller.methodNotSupported(req, res, next);
             next.should.have.been.called.and.calledWithExactly(sinon.match.instanceOf(Error));
             let err = next.args[0][0];
-            err.statusCode.should.equal(405);
+            err.status.should.equal(405);
+            err.code.should.equal('METHOD_NOT_SUPPORTED');
         });
     });
 

diff --git a/test/controller/spec.lifecycle.js b/test/controller/spec.lifecycle.js
@@ -183,7 +183,7 @@ describe('Controller Lifecycle', () => {
                 next.should.have.been.called;
                 let err = next.args[0][0];
                 err.should.be.instanceOf(Error);
-                err.statusCode.should.equal(405);
+                err.status.should.equal(405);
                 done();
             };