Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldmap #26

Merged
merged 10 commits into from
Feb 7, 2023
Merged

Fieldmap #26

merged 10 commits into from
Feb 7, 2023

Conversation

kjvbrt
Copy link
Contributor

@kjvbrt kjvbrt commented Dec 13, 2022

This PR implements magnetic field described with the help of the fieldmap. Requires 6 input vectors: position: x, y, z and filed: Bx, By, Bz.

@kjvbrt kjvbrt requested a review from BrieucF January 31, 2023 15:02
Copy link
Contributor

@BrieucF BrieucF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! Only very minor things

@BrieucF
Copy link
Contributor

BrieucF commented Feb 6, 2023

Great thanks! +1 on my side

@kjvbrt kjvbrt merged commit a9b6158 into HEP-FCC:main Feb 7, 2023
@kjvbrt kjvbrt deleted the fieldmap branch February 21, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants