-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade python to 3.12, lxml to 5.x #14
Conversation
pyproject.toml
Outdated
cryptography = ">=2.8" | ||
lxml = ">=4.4.1" | ||
lxml = "^5.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason we need 5.2 (as opposed to say 'any 5.x')?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not really, let me change to 5.x 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ojii Changed to ^5.0
Merging this in 🙏 |
Additionally added pypi release GHA.