-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option for mob projectiles changing blocks in claims #2099
Add config option for mob projectiles changing blocks in claims #2099
Conversation
Given that other mob grief is allowed, I'm thinking this should be allowed by default too, thoughts? |
Makes sense to me, it's such a niche thing. I guess we could run a target check to make sure the target is either a non-player or trusted if we want to be super safe. Honestly if we do that we probably shouldn't even include a config option. |
To prevent elaborate player traps? Or am I understanding this wrong? |
To prevent luring skeletons into farms and breaking things with their arrows, for example. If we're guarding against the potential malicious usage I don't see why it needs a config option given how opinionated GP is in general. |
Ah. Do we do checks like that for e.g. creepers being lured in now too? My current understanding is that mob-performed stuff, even with hostile mobs, are currently permissible since that's seen to be an issue with how the player has built their structures. E.g., mobs can trample crops. |
That's true, I guess this does fall under general mob grief, which GP does have config settings for. |
I'll want to revisit this sort of stuff with v17 - my thinking is to simplify config to either deny all or allow all, and have addons provide more granular controls later on. |
Some builds that rely on mob projectiles changing blocks, like TNT-powered music disc farms where skeleton arrows must ignite TNT, are completely broken in claims.
EntityEventHandler.handleProjectileChangeBlock
handles these interactions but only allows projectiles to change blocks if:There's no exception for mob projectiles and no way to allow mob projectiles to change blocks, so I went ahead and added a config option to do just that. This allows TNT music disc farms and other builds relying on the mechanic to work again, as tested on a Paper 1.20 server.
The default for this config value is false, which means default behavior is unchanged unless a server owner specifically toggles
MobProjectilesChangeBlocks
totrue
.