Explicitly Use __ldg on Pointer Derefs #1800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch perftest |
|
launch jenkins |
|
Hi there, this is jenkins continuous integration... |
havogt
requested changes
Aug 2, 2024
| @@ -16,6 +16,10 @@ | |||
| #include "./common_interface.hpp" | |||
| #include "./executor.hpp" | |||
|
|
|||
| #if defined(__CUDA_ARCH__) && __CUDA_ARCH__ >= 350 | |||
There was a problem hiding this comment.
We only support cuda >= 11.0, therefore anyway no support for < 350
Comment on lines
+51
to
+56
| #if defined(__CUDA_ARCH__) && __CUDA_ARCH__ >= 350 | ||
| if constexpr (std::is_pointer_v<decltype(it.m_ptr)> && | ||
| is_texture_type<std::decay_t<std::remove_pointer_t<decltype(it.m_ptr)>>>::value) { | ||
| return __ldg(it.m_ptr); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
what about introducing a function like
deref_as_const?
|
Closed in favor of #1802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the
__ldgintrinsic on (scalar) pointer derefs in SID neighbor tables and derefs within the fn cartesian and unstructured backends.