Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nanobind adapter backward compatible #1790

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Make nanobind adapter backward compatible #1790

merged 3 commits into from
Jun 25, 2024

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Jun 19, 2024

No description provided.

@havogt havogt requested a review from fthaler June 19, 2024 12:35
fthaler
fthaler requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@fthaler fthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note: I haven’t tested with GT4Py, assuming you did.

include/gridtools/storage/adapter/nanobind_adapter.hpp Outdated Show resolved Hide resolved
include/gridtools/storage/adapter/nanobind_adapter.hpp Outdated Show resolved Hide resolved
include/gridtools/storage/adapter/nanobind_adapter.hpp Outdated Show resolved Hide resolved
include/gridtools/storage/adapter/nanobind_adapter.hpp Outdated Show resolved Hide resolved
@havogt
Copy link
Contributor Author

havogt commented Jun 24, 2024

launch jenkins

@havogt havogt requested a review from fthaler June 24, 2024 07:23
@havogt
Copy link
Contributor Author

havogt commented Jun 24, 2024

launch jenkins

@havogt
Copy link
Contributor Author

havogt commented Jun 24, 2024

tested locally, would be good to test it in the gt4py cscs-ci container on daint before merge (but daint is down now)

@havogt
Copy link
Contributor Author

havogt commented Jun 25, 2024

launch jenkins

@havogt
Copy link
Contributor Author

havogt commented Jun 25, 2024

CI passed except ault and dom which are offline

@havogt
Copy link
Contributor Author

havogt commented Jun 25, 2024

test in gt4py ci image seems to work

@havogt havogt merged commit 1508d09 into GridTools:master Jun 25, 2024
66 of 67 checks passed
@havogt havogt deleted the nanobind_backwards_compatible branch June 25, 2024 18:31
havogt added a commit that referenced this pull request Jun 26, 2024
@havogt
Make nanobind adapter backward compatible (#1790)
2dde2b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fthaler fthaler fthaler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havogt @fthaler