Sid: dimension to tuple like #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch jenkins |
|
launch perftests |
|
launch perftests |
|
launch jenkins |
|
launch perftests |
|
launch jenkins |
|
launch perftests |
havogt
commented
Apr 6, 2023
| GT_REGRESSION_TEST(copy_stencil_tuple_tuple, test_environment<>, stencil_backend_t) { | ||
| // expected to perform bad on GPU because array of structures | ||
| using float_t = typename TypeParam::float_t; | ||
| auto in = [](int i, int j, int k) { return tuple{i + j + k, i + j + k + 1, i + j + k + 2, i + j + k + 3}; }; |
There was a problem hiding this comment.
- try array
- then use 5 elements (because 4 floats should be a single load in cuda)
There was a problem hiding this comment.
Hmm. Performance is bad for array<float,4>, too. No idea why this is not translated to a float4 load.
fthaler
requested changes
Apr 6, 2023
|
launch perftests |
|
launch perftests |
|
launch perftests |
havogt
commented
Apr 12, 2023
|
launch jenkins |
|
launch perftests |
havogt
commented
Apr 14, 2023
Allows to call `total_size` with empty tuple, returns 1.
…id_dimension_to_tuple_like
fthaler
requested changes
Apr 20, 2023
|
launch jenkins |
|
launch perftests |
|
launch jenkins |
|
launch perftests |
|
launch jenkins |
fthaler
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sid transformations utility which translates a sid with dimension
Dand element typeTto a sid withDremoved and type istuple<T>like, with tuple_sizeNforsid::dimension_to_tuple_like<D, N>(sid).Additional: