Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Skip Value Check #1721

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

fthaler
Copy link
Contributor

@fthaler fthaler commented Jul 19, 2022

Seems to drastically improve performance (due to compiler better recognizing optimization potential).
Further, provides up-to-date performance references and an updated update_references.sh as the Jenkins setup now requires authentication to access the performance results.

@fthaler
Copy link
Contributor Author

fthaler commented Jul 19, 2022

launch jenkins

@fthaler
Copy link
Contributor Author

fthaler commented Jul 19, 2022

launch perftest

@mroethlin
Copy link

I can confirm that this PR in conjunction with this other PR in icon4py improves performance to dusk/dawn levels.

@fthaler fthaler requested a review from havogt July 19, 2022 14:39
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We need to update the performance reference.

@fthaler
Copy link
Contributor Author

fthaler commented Jul 20, 2022

launch jenkins

@fthaler
Copy link
Contributor Author

fthaler commented Jul 20, 2022

launch perftest

@fthaler fthaler requested a review from havogt July 20, 2022 11:38
@fthaler
Copy link
Contributor Author

fthaler commented Jul 20, 2022

Looks good! We need to update the performance reference.

I actually also had to update the update_references.sh as they finally managed to require to set up encryption and authentication for the Jenkins server. It’s just included in this PR now, let me know if you think I should split it.

Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to split in my opinion.

@fthaler fthaler merged commit 43ad549 into GridTools:master Jul 20, 2022
@fthaler fthaler deleted the fix-skip-value-performance branch July 20, 2022 11:55
havogt pushed a commit to havogt/gridtools that referenced this pull request Aug 3, 2022
This alternative check drastically improves performance when using NVCC (due to compiler better recognizing optimization potential).
Further, provides up-to-date performance references and an updated update_references.sh as the Jenkins setup now requires authentication to access the performance results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants