-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative Skip Value Check #1721
Conversation
launch jenkins |
launch perftest |
I can confirm that this PR in conjunction with this other PR in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We need to update the performance reference.
launch jenkins |
launch perftest |
I actually also had to update the update_references.sh as they finally managed to require to set up encryption and authentication for the Jenkins server. It’s just included in this PR now, let me know if you think I should split it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to split in my opinion.
This alternative check drastically improves performance when using NVCC (due to compiler better recognizing optimization potential). Further, provides up-to-date performance references and an updated update_references.sh as the Jenkins setup now requires authentication to access the performance results.
Seems to drastically improve performance (due to compiler better recognizing optimization potential).
Further, provides up-to-date performance references and an updated update_references.sh as the Jenkins setup now requires authentication to access the performance results.