CTAD for simple_ptr_holder #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
havogt
commented
Feb 21, 2022
| // CTAD for aggregates works | ||
| #else | ||
| // Enables CTAD in C++17. | ||
| simple_ptr_holder() = default; |
There was a problem hiding this comment.
default ctor only there for some test cases that rely on default init.
anstaf
approved these changes
Feb 21, 2022
| GT_TARGET GT_FORCE_INLINE constexpr T const &operator()() const { return m_val; } | ||
| }; | ||
|
|
||
| template <class T> | ||
| constexpr simple_ptr_holder<T> make_simple_ptr_holder(T const &ptr) { | ||
| [[deprecated("use simple_ptr_holder class template argument deduction")]] constexpr simple_ptr_holder<T> |
There was a problem hiding this comment.
Are you sure you want to keep the maker? I thought it is not the part of the public API.
There was a problem hiding this comment.
I'll keep it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it's worth trading aggregate for CTAD. When I looked at make_simple_ptr_holder, I missed that aggregate CTAD is a C++20 feature.