Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduction #1590

Merged
merged 19 commits into from
Jan 8, 2021
Merged

Reduction #1590

merged 19 commits into from
Jan 8, 2021

Conversation

anstaf
Copy link
Contributor

@anstaf anstaf commented Dec 3, 2020 •
edited
Loading

  • introduce reduction framework within gridtools
  • implement naive and gpu reduction backends

@anstaf anstaf requested a review from havogt December 3, 2020 10:55
@anstaf
Copy link
Contributor Author

anstaf commented Dec 3, 2020

launch jenkins

1 similar comment
@anstaf
Copy link
Contributor Author

anstaf commented Dec 3, 2020

launch jenkins

@anstaf anstaf requested a review from fthaler December 3, 2020 12:30
fthaler
fthaler requested changes Dec 3, 2020
View reviewed changes
include/gridtools/common/ct_dispatch.hpp Show resolved Hide resolved
include/gridtools/common/hugepage_alloc.hpp Outdated Show resolved Hide resolved
include/gridtools/common/ct_dispatch.hpp Show resolved Hide resolved
include/gridtools/reduction/gpu.hpp Outdated Show resolved Hide resolved
include/gridtools/reduction/gpu.hpp Outdated Show resolved Hide resolved
include/gridtools/reduction/gpu.hpp Outdated Show resolved Hide resolved
include/gridtools/reduction/naive.hpp Outdated Show resolved Hide resolved
include/gridtools/reduction/gpu.hpp Outdated Show resolved Hide resolved
include/gridtools/reduction/gpu.hpp Show resolved Hide resolved
include/gridtools/reduction/gpu.hpp Outdated Show resolved Hide resolved
anstaf and others added 4 commits December 3, 2020 16:27
@anstaf @fthaler
Update include/gridtools/reduction/gpu.hpp
b97fa1c 
Co-authored-by: Felix Thaler <felix.thaler@nummi.ch>
@anstaf @fthaler
Update include/gridtools/reduction/gpu.hpp
10e84b3 
Co-authored-by: Felix Thaler <felix.thaler@nummi.ch>
@anstaf @fthaler
Update tests/include/reduction_select.hpp
6699e89 
Co-authored-by: Felix Thaler <felix.thaler@nummi.ch>
@anstaf
address PR comments
d118c3e
@anstaf anstaf requested a review from fthaler December 3, 2020 17:13
@anstaf
Copy link
Contributor Author

anstaf commented Dec 3, 2020

launch jenkins

@fthaler
Copy link
Contributor

fthaler commented Dec 16, 2020

Let’s wait for the merge of #1592, then the CI is based on a more recent HIP version and possibly required fixes for HIP can be based on this version.

@fthaler
Copy link
Contributor

fthaler commented Dec 16, 2020

launch jenkins

fthaler
fthaler requested changes Dec 16, 2020
View reviewed changes
include/gridtools/reduction/gpu.hpp Outdated Show resolved Hide resolved
include/gridtools/reduction/gpu.hpp Show resolved Hide resolved
include/gridtools/reduction/gpu.hpp Outdated Show resolved Hide resolved
include/gridtools/reduction/gpu.hpp Show resolved Hide resolved
@fthaler
Copy link
Contributor

fthaler commented Jan 7, 2021

launch jenkins

@fthaler
Copy link
Contributor

fthaler commented Jan 7, 2021

launch jenkins

@fthaler
Copy link
Contributor

fthaler commented Jan 7, 2021

HIP reduction issue reported to AMD: ROCm/HIP#2212

@fthaler
Copy link
Contributor

fthaler commented Jan 8, 2021

launch jenkins

@fthaler fthaler self-requested a review January 8, 2021 07:48
@anstaf anstaf merged commit a60823c into GridTools:master Jan 8, 2021
@anstaf anstaf deleted the reduce branch February 26, 2021 09:14
@havogt havogt mentioned this pull request Mar 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fthaler fthaler fthaler approved these changes

@havogt havogt Awaiting requested review from havogt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anstaf @fthaler