Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various cleanups and c++17 related changes #1579

Merged
merged 10 commits into from
Oct 14, 2020
Merged

various cleanups and c++17 related changes #1579

merged 10 commits into from
Oct 14, 2020

Conversation

anstaf
Copy link
Contributor

@anstaf anstaf commented Oct 12, 2020

No description provided.

@anstaf anstaf requested a review from havogt October 12, 2020 13:36
@anstaf
Copy link
Contributor Author

anstaf commented Oct 12, 2020

launch jenkins

@anstaf
Copy link
Contributor Author

anstaf commented Oct 12, 2020

launch jenkins

havogt
havogt requested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you quickly walk me through some of the small changes? For some it will take me unreasonably long time to reason about them.

include/gridtools/common/iterate_on_host_device.hpp Show resolved Hide resolved
include/gridtools/gcl/high_level/numerics.hpp Show resolved Hide resolved
include/gridtools/stencil/frontend/cartesian/accessor.hpp Show resolved Hide resolved
tests/regression/horizontal_diffusion.cpp Show resolved Hide resolved
include/gridtools/common/layout_map.hpp Outdated Show resolved Hide resolved
@anstaf
Copy link
Contributor Author

anstaf commented Oct 13, 2020

launch jenkins

anstaf and others added 3 commits October 13, 2020 14:37
@anstaf
Copy link
Contributor Author

anstaf commented Oct 13, 2020

launch jenkins

1 similar comment
@anstaf
Copy link
Contributor Author

anstaf commented Oct 13, 2020

launch jenkins

@anstaf anstaf requested a review from havogt October 13, 2020 13:50
@anstaf
Copy link
Contributor Author

anstaf commented Oct 13, 2020

launch jenkins

havogt
havogt approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previously commented test is still failing. Other than that, it's approved.

@anstaf
Copy link
Contributor Author

anstaf commented Oct 14, 2020

launch jenkins

@anstaf
Copy link
Contributor Author

anstaf commented Oct 14, 2020

launch jenkins

@anstaf anstaf merged commit 1ffd6fb into GridTools:master Oct 14, 2020
@anstaf anstaf deleted the for_each branch February 26, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havogt havogt havogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anstaf @havogt