Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hold the sids within sid::composite as tuple #1564

Merged
merged 7 commits into from
Oct 1, 2020
Merged

Hold the sids within sid::composite as tuple #1564

merged 7 commits into from
Oct 1, 2020

Conversation

anstaf
Copy link
Contributor

@anstaf anstaf commented Sep 29, 2020

No description provided.

@anstaf anstaf requested a review from havogt September 29, 2020 15:15
@anstaf
Copy link
Contributor Author

anstaf commented Sep 29, 2020

launch jenkins

@anstaf
Copy link
Contributor Author

anstaf commented Sep 29, 2020

launch jenkins

@anstaf
Copy link
Contributor Author

anstaf commented Sep 29, 2020

launch jenkins

@anstaf
Copy link
Contributor Author

anstaf commented Sep 29, 2020

launch jenkins

@anstaf anstaf changed the title Hold the sids within sid::comosite as std::tuple Hold the sids within sid::comosite as tuple Sep 29, 2020
@anstaf anstaf changed the title Hold the sids within sid::comosite as tuple Hold the sids within sid::composite as tuple Sep 29, 2020
@anstaf
Copy link
Contributor Author

anstaf commented Sep 29, 2020

launch jenkins

1 similar comment
@anstaf
Copy link
Contributor Author

anstaf commented Sep 30, 2020

launch jenkins

havogt
havogt reviewed Sep 30, 2020
View reviewed changes
include/gridtools/sid/composite.hpp Outdated Show resolved Hide resolved
include/gridtools/sid/composite.hpp Outdated Show resolved Hide resolved
@anstaf anstaf requested a review from havogt September 30, 2020 14:25
havogt
havogt requested changes Oct 1, 2020
View reviewed changes
include/gridtools/sid/composite.hpp
GT_FORCE_INLINE_LAMBDA
// The failure is observed with 9.3 as well even though they say it was already fixed there.
// gcc 10.1, 10.2 fails here as well. Disabling for all gcc 9 and 10 versions...
#if defined(__clang__) || !defined(__GNUC__) || (__GNUC__ != 9 && __GNUC__ != 10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#if defined(__clang__) || !defined(__GNUC__) || (__GNUC__ != 9 && __GNUC__ != 10)
#if !defined(__GNUC__) || (__GNUC__ != 9 && __GNUC__ != 10)

I think the clang check is useless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.
Clang defines GNUC / GNUC_MINOR / GNUC_PATCHLEVEL according to the version of gcc that it claims full compatibility with.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks!

@anstaf anstaf requested a review from havogt October 1, 2020 08:24
@anstaf
Copy link
Contributor Author

anstaf commented Oct 1, 2020

launch jenkins

@anstaf anstaf merged commit 2575443 into GridTools:master Oct 1, 2020
@anstaf anstaf deleted the fix_c17 branch February 26, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havogt havogt havogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anstaf @havogt