Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible access violation in storage builder #1534

Merged
merged 4 commits into from
Jul 13, 2020
Merged

Fix possible access violation in storage builder #1534

merged 4 commits into from
Jul 13, 2020

Conversation

anstaf
Copy link
Contributor

@anstaf anstaf commented Jul 9, 2020

No description provided.

@anstaf anstaf requested a review from havogt July 9, 2020 10:32
@anstaf
Copy link
Contributor Author

anstaf commented Jul 9, 2020

launch jenkins

havogt
havogt requested changes Jul 10, 2020
View reviewed changes
include/gridtools/storage/builder.hpp Outdated Show resolved Hide resolved
@anstaf
Copy link
Contributor Author

anstaf commented Jul 10, 2020

launch jenkins

@anstaf anstaf requested a review from havogt July 10, 2020 08:24
@havogt
Copy link
Contributor

havogt commented Jul 10, 2020

launch jenkins

1 similar comment
@havogt
Copy link
Contributor

havogt commented Jul 13, 2020

launch jenkins

@havogt
Copy link
Contributor

havogt commented Jul 13, 2020

I'll merge. (failed because tsa not available)

@havogt havogt changed the title fix possible access violation in storage builder Fix possible access violation in storage builder Jul 13, 2020
@havogt havogt merged commit b96b672 into GridTools:master Jul 13, 2020
@anstaf anstaf deleted the storage_fix branch July 22, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havogt havogt havogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anstaf @havogt