Export compilation type #1387
Merged
Export compilation type #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
reviewed
Dec 9, 2019
| set(GRIDTOOLS_CUDA_COMPILATION_TYPE "@GT_CUDA_COMPILATION_TYPE@") | ||
| endif() | ||
|
|
||
| if(GRIDTOOLS_ENABLE_PERFORMANCE_METERS) |
There was a problem hiding this comment.
Unrelated to this PR, but I think we shouldn’t put enable performance meters in the config. But probably it is not worth fixing as the meters will disappear in 2.0 anyway...
There was a problem hiding this comment.
yes I agree that might be something that we just want to document because we might want to enable it for certain targets... let's wait for 2.0 and reiterate the config then, ok?
Merged
|
launch jenkins |
havogt
approved these changes
Dec 10, 2019
|
launch strgrid |
lukasm91
added a commit
to lukasm91/gridtools
that referenced
this pull request
Dec 10, 2019
havogt
pushed a commit
that referenced
this pull request
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.