Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance for CUDA >= 9.2 (master) #1327

Merged
merged 22 commits into from
Jul 8, 2019
Merged

Fix performance for CUDA >= 9.2 (master) #1327

merged 22 commits into from
Jul 8, 2019

Conversation

lukasm91
Copy link
Contributor

@lukasm91 lukasm91 commented Jul 1, 2019 •
edited
Loading

  • sets GT_CONSTEXPR to constexpr for nvcc
  • introduces const_ref to fix performance for CUDA >= 9.2 (T for small data types, T const& for large data types)

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 1, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 1, 2019

do perftest

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 1, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 1, 2019

launch strgridlaunch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 1, 2019

launch strgrid

2 similar comments
@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 2, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 2, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 3, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 3, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 3, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 4, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 4, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 4, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 4, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 4, 2019

do perftest

@lukasm91 lukasm91 changed the title Fix performance for CUDA >= 9.2 Fix performance for CUDA >= 9.2 [WIP] Jul 4, 2019
@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 5, 2019

launch icgrid

@lukasm91 lukasm91 changed the title Fix performance for CUDA >= 9.2 [WIP] Fix performance for CUDA >= 9.2 (master) [WIP] Jul 5, 2019
@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 5, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 5, 2019

launch icgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 5, 2019

do perftest

@lukasm91 lukasm91 requested a review from anstaf July 5, 2019 06:29
@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 5, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented Jul 5, 2019

do perftest

anstaf
anstaf approved these changes Jul 5, 2019
View reviewed changes
unit_tests/common/test_pair.cpp Outdated Show resolved Hide resolved
@lukasm91 lukasm91 changed the title Fix performance for CUDA >= 9.2 (master) [WIP] Fix performance for CUDA >= 9.2 (master) Jul 8, 2019
@anstaf anstaf merged commit 9bb2d64 into GridTools:master Jul 8, 2019
havogt added a commit that referenced this pull request Jul 16, 2019
@havogt
Revert "Fix performance for CUDA >= 9.2 (master) (#1327)"
27a49d3 
This reverts commit 9bb2d64.
@havogt havogt mentioned this pull request Jul 16, 2019
Merged
havogt added a commit that referenced this pull request Jul 18, 2019
@havogt
Revert "Fix performance for CUDA >= 9.2 (master) (#1327)" (#1339)
b489fa6 
Reverts #1327

The performance problem is not fixed, instead the reference was broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anstaf anstaf anstaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasm91 @anstaf