Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance for CUDA 9.2 / 10.0 #1281

Merged
merged 39 commits into from
May 3, 2019

Conversation

lukasm91
Copy link
Contributor

@lukasm91 lukasm91 commented Apr 23, 2019

  • make constexpr compiler dependent whenever possible (replace with macro GT_CONSTEXPR)
  • remove const_expr::move and const_expr::forward
  • add wstd::move and wstd::forward (move and forward are only constexpr if compiler does not suffer from it)

@lukasm91
Copy link
Contributor Author

do perftest

@lukasm91
Copy link
Contributor Author

do perftest

@lukasm91
Copy link
Contributor Author

do perftest

@lukasm91
Copy link
Contributor Author

do perftest

@lukasm91
Copy link
Contributor Author

do perftest

@lukasm91
Copy link
Contributor Author

do perftest

1 similar comment
@lukasm91
Copy link
Contributor Author

do perftest

@lukasm91
Copy link
Contributor Author

do perftest

@lukasm91
Copy link
Contributor Author

do perftest

1 similar comment
@lukasm91
Copy link
Contributor Author

do perftest

@lukasm91
Copy link
Contributor Author

launch strgrid

@lukasm91
Copy link
Contributor Author

launch icgrid

@lukasm91
Copy link
Contributor Author

do perftest

@lukasm91
Copy link
Contributor Author

launch strgrid

@lukasm91
Copy link
Contributor Author

launch icgrid

@lukasm91
Copy link
Contributor Author

do perftest

@lukasm91 lukasm91 changed the title no constexpr on device (experimental branch for perftest) Fix performance for CUDA 9.2 / 10.0 Apr 29, 2019
Copy link
Contributor

@anstaf anstaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove formating changes in meta from this PR.

include/gridtools/common/generic_metafunctions/utility.hpp Outdated Show resolved Hide resolved
include/gridtools/meta/fold.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@anstaf anstaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new usages of std::move/std::forward are arrived with the recent Hannes PR. Please fix them as well.

@lukasm91
Copy link
Contributor Author

lukasm91 commented May 2, 2019

launch strgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented May 2, 2019

launch icgrid

@lukasm91
Copy link
Contributor Author

lukasm91 commented May 3, 2019

do perftest

@lukasm91
Copy link
Contributor Author

lukasm91 commented May 3, 2019

do perftest

@anstaf anstaf merged commit 9fa2862 into GridTools:master May 3, 2019
@lukasm91 lukasm91 deleted the no_constexpr_on_device branch May 3, 2019 17:59
havogt pushed a commit to havogt/gridtools that referenced this pull request May 7, 2019
- make constexpr compiler dependent whenever possible (replace with macro `GT_CONSTEXPR`)
- remove `const_expr::move` and `const_expr::forward`
- add `wstd::move` and `wstd::forward` (move and forward are only constexpr if compiler does not suffer from it)
havogt pushed a commit that referenced this pull request May 16, 2019
- make constexpr compiler dependent whenever possible (replace with macro `GT_CONSTEXPR`)
- remove `const_expr::move` and `const_expr::forward`
- add `wstd::move` and `wstd::forward` (move and forward are only constexpr if compiler does not suffer from it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants