Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove backend and backend_base Classes #1244

Merged
merged 14 commits into from
Mar 29, 2019
Merged

Remove backend and backend_base Classes #1244

merged 14 commits into from
Mar 29, 2019

Conversation

fthaler
Copy link
Contributor

@fthaler fthaler commented Mar 28, 2019 •
edited
Loading

  • Removes the obsolete backend and backend_base classes.
  • backend_t::make_global_parameter(…) is now make_global_parameter<backend_t>(). Same for update_global_parameter.
  • backend_t::storage_traits_t is gone (use storage_traits<backend_t> instead).
  • target::X is now called backend::X.

@fthaler
Copy link
Contributor Author

fthaler commented Mar 28, 2019

launch strgrid

@fthaler
Copy link
Contributor Author

fthaler commented Mar 28, 2019

launch icgrid

@fthaler
Copy link
Contributor Author

fthaler commented Mar 29, 2019

launch strgrid

@fthaler
Copy link
Contributor Author

fthaler commented Mar 29, 2019

launch icgrid

@fthaler
Copy link
Contributor Author

fthaler commented Mar 29, 2019

launch strgrid

@fthaler
Copy link
Contributor Author

fthaler commented Mar 29, 2019

launch icgrid

@fthaler fthaler requested a review from anstaf March 29, 2019 08:32
havogt
havogt requested changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this, we should also change the CMake variables GT_ENABLE_TARGET_X

@fthaler
Copy link
Contributor Author

fthaler commented Mar 29, 2019

If we do this, we should also change the CMake variables GT_ENABLE_TARGET_X

Done. Hope I found all related CMake variables.

@fthaler
Copy link
Contributor Author

fthaler commented Mar 29, 2019

launch strgrid

@fthaler
Copy link
Contributor Author

fthaler commented Mar 29, 2019

launch icgrid

@fthaler fthaler requested a review from havogt March 29, 2019 10:55
anstaf
anstaf approved these changes Mar 29, 2019
View reviewed changes
include/gridtools/stencil_composition/tmp_storage.hpp Outdated
@@ -19,7 +19,7 @@
* where:
* MaxExtent - integral_constant with maximal absolute extent in I direction.
* TODO(anstaf): change to fully specified max extent
* Backend - instantiation of backend tag
* Backend - instantiation of target
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@fthaler
Copy link
Contributor Author

fthaler commented Mar 29, 2019

Tests have passed, last change was just in a comment.

@fthaler
Copy link
Contributor Author

fthaler commented Mar 29, 2019

do perftest

@anstaf anstaf merged commit fd83194 into GridTools:master Mar 29, 2019
@fthaler fthaler deleted the remove-backend branch April 3, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anstaf anstaf anstaf approved these changes

@havogt havogt Awaiting requested review from havogt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fthaler @havogt @anstaf