Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when item's burn time * 12 > Integer.MAX_VALUE,it can't be burned. #2001

Open
wants to merge 1 commit into
base: 1.20.1
Choose a base branch
from

Conversation

liansishen
Copy link
Contributor

What

Fix when item's burn time * 12 > Integer.MAX_VALUE,it can't be burned.

Implementation Details

Avaritia's star fuel have a burn time with Integer.MAX_VALUE, it can't be burned in GTM's machines.

Outcome

star fuel now can burn in GTM's machines with LARGE_BOILER_RECIPES.

Additional Information

This section is for screenshots to demonstrate any GUI or rendering changes, or any other additional information that reviewers should be aware of.

Potential Compatibility Issues

This section is for defining possible compatibility issues. It must be used when there are API changes, item/block/material/machine changes, or recipe changes.

Please fill in as much useful information as possible. Also, please remove all unused sections, including this and the other explanations.

@liansishen liansishen requested a review from a team as a code owner September 22, 2024 13:51
Copy link
Member

@screret screret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this isn't a fix.

@liansishen
Copy link
Contributor Author

no, this isn't a fix.

so, you mean this is needn't to change?

@screret
Copy link
Member

screret commented Sep 22, 2024

No, I mean that this isn't a good way to approach fixing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants