Add NNC for value of fluid vein to avoid NPE when updating maps from lower versions #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added NNC for value of fluid vein to avoid NPE when updating maps from lower versions
|
The vein data is not lost in my map. |
screret
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added an NonNullCheck to FluidVeinWorldEntry.java. We noted that the key of fluid vein is checked by now, but the value is ignored, causing a crash when entering maps from a lower version of GTCEu, e.g. 1.2.1 (we used this version for the proper work of parallel hatch, which is very important but cannot work properly in 1.2.3, and the problem is hopefully already fixed in 1.2.3.a).
A detailed stack trace of the crash is provided:
Crash Report
Implementation Details
A version converter of former maps' fluid vein data may be developed, instead of this straightforward fix.
Outcome
The crash is avoided, and former maps can be entered and played.
Potential Compatibility Issues
This may cause a lose of former maps' fluid vein data.