Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor directory and file setup checks in tests #1340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tiffanny29631
Copy link
Contributor

This commit refactors a more deterministic approach using channels to signal the completion of setup tasks. This change ensures that the tests proceed only after the necessary conditions are met or fail immediately upon setup errors, thus improving test stability.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tiffanny29631. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

}()

// Wait for setup to complete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of doing the setup in a separate goroutine if we immediately block for the goroutine to finish? My understanding is that the intent of this test was to write to the filesystem async while SourceCommitAndDirWithRetry is running to simulate the sidecar behavior

@nan-yu
Copy link
Contributor

nan-yu commented Jul 19, 2024

What's the intent of this commit, fixing the flakiness in TestSourceCommitAndDirWithRetry?

I took a look at the presubmit failures in this month. Besides a bunch of linter errors, there're 12 test failures for TestRoot_SourceReconcilerErrorsMetricValidation, and 1 test failure for TestBackoffRetryCount. It would be more helpful to stabilize the other two unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants