chore: bump manifest headers to 2024 #1092
Conversation
The license headers for the manifests are generated as part of the presubmits, and need to be bumped for the new year.
|
/assign @karlkfi |
|
My understanding is that Google policy is to only update copyright years on file creation, not updates (go/copyright#the-year). Is this change needed to satisfy validation? If so, it seems like maybe the tooling doesn't match the policy. |
Yes, this is needed to satisfy the presubmit validation. Currently the CRDs are generated from code and headers are injected, and then the tooling checks if there is a git diff. So the validation now fails since the generated headers have the new year. |
|
Can you log a bug to fix the automation to preserve the earliest copyright date, instead of always re-generating it? |
Created a bug |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 4dee981
into
GoogleContainerTools:main
The license headers for the manifests are generated as part of the presubmits, and need to be bumped for the new year.
The license headers for the manifests are generated as part of the presubmits, and need to be bumped for the new year.