Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove GVK from typed objects #1054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Remove GVK from typed objects #1054

wants to merge 1 commit into from

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Nov 22, 2023 •
edited
Loading

  • Fix all the tests that required or assumed typed objects always have GKV set.
  • Panic from IDOf, GKNNOf, and GVKNNOf if the typed object is not in the scheme. In most cases this only affects tests. Non-tests will need to be refactored to handle the possible error without panicing.

TODO: Handle deprecation failures. Route through scheme and errors.

Extracted:

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from karlkfi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karlkfi
[WIP] Remove GVK from typed objects
07a8346 
- Fix all the tests that required or assumed typed objects always
  have GKV set.
- Panic from IDOf, GKNNOf, and GVKNNOf if the typed object is not
  in the scheme. In most cases this only affects tests. Non-tests
  will need to be refactored to handle the possible error without
  panicing.
@google-oss-prow Google OSS Prow
Copy link

@karlkfi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kpt-config-sync-presubmit-e2e-multi-repo-test-group2 07a8346 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group2
kpt-config-sync-presubmit-e2e-multi-repo-test-group3 07a8346 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group3
kpt-config-sync-presubmit-e2e-multi-repo-test-group1 07a8346 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group1
kpt-config-sync-presubmit 07a8346 link true /test kpt-config-sync-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiyanmeng haiyanmeng Awaiting requested review from haiyanmeng

@sdowell sdowell Awaiting requested review from sdowell

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karlkfi