Only build required docker images for integration tests #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvgw
force-pushed
the
u/cvgw/improve-integration-test-runner
branch
from
fbda4c0
to
addf04f
Compare
cvgw
changed the title
cvgw
force-pushed
the
u/cvgw/improve-integration-test-runner
branch
from
addf04f
to
14542a0
Compare
Only build the docker images required for the integration tests which will be executed rather than building all docker images every time.
cvgw
force-pushed
the
u/cvgw/improve-integration-test-runner
branch
from
14542a0
to
c2645b2
Compare
tejal29
requested changes
Dec 9, 2019
tejal29
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #897
Description
Only build docker images for the integration tests that actually run rather than for all integration tests regardless of which will run.
This will greatly reduce the time it takes to run an individual integration test.
Looking at the kokoro history, this change doesn't seem to impact performance when running the entire test suite.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes