Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILD_ARGs to ease use of proxy #810

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

tibers
Copy link
Contributor

@tibers tibers commented Oct 7, 2019

Fixes #809 .

Description

Add BUILD_ARG which will reference either the environment or someone customizing the makefile. Can be used like BUILD_ARG = --build-arg https_proxy=http://myproxy:3128 --build-arg http_proxy=http://myproxy:3128 to improve the users proxy experience, for instance.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- Skaffold config changes like
  e.g. "Add buildArgs to `Kustomize` deployer skaffold config."
- Bug fixes
  e.g. "Improve skaffold init behaviour when tags are used in manifests"
- Any changes in skaffold behavior
  e.g. "Artiface cachine is turned on by default."

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tibers
Copy link
Contributor Author

tibers commented Oct 7, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tejal29 tejal29 merged commit b23b09d into GoogleContainerTools:master Oct 16, 2019
@slmagus
Copy link

slmagus commented Oct 16, 2019

Ah ha! Thank you!

No worries, I got a PR in #810 that fixes it and make sure make images doesn't fail so hard in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kaniko needs better proxy handling
5 participants