Fix #691 - ADD does not understand ENV variables

[N4rm0]

Fixes #691

The issue was that function ResolveEnvironmentReplacementList tries to check if value is a remote url. However, it misses the case the url is enclosed in the environment variable.

I made an additional check to fix #691, but IHMO I think it would be cleaner to remove the flag "isFilepath", and let the function ResolveEnvironmentReplacement handle the remote file url case.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[N4rm0]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[tejal29]

Looks like the integration test failed due to-

Error building images: Failed to build image gcr.io/kaniko-test/docker-dockerfile_test_whitelist with kaniko command "[docker run -v /home/kbuilder/.config/gcloud:/root/.config/gcloud -v /tmpfs/tmp/171480209:/kaniko/benchmarks -v /usr/local/go/src/github.com/GoogleContainerTools/kaniko/integration:/workspace -e BENCHMARK_FILE=false executor-image -f /workspace/dockerfiles/Dockerfile_test_whitelist -d gcr.io/kaniko-test/kaniko-dockerfile_test_whitelist  -c /workspace]": exit status 1 INFO[0000] Resolved base name debian@sha256:38236c068c393272ad02db100e09cac36a5465149e2924a035ee60d6c60c38fe to debian@sha256:38236c068c393272ad02db100e09cac36a5465149e2924a035ee60d6c60c38fe 
INFO[0000] Resolved base name debian@sha256:38236c068c393272ad02db100e09cac36a5465149e2924a035ee60d6c60c38fe to debian@sha256:38236c068c393272ad02db100e09cac36a5465149e2924a035ee60d6c60c38fe 
INFO[0000] Error while retrieving image from cache: getting file info: stat /cache/sha256:38236c068c393272ad02db100e09cac36a5465149e2924a035ee60d6c60c38fe: no such file or directory 
INFO[0000] Downloading base image debian@sha256:38236c068c393272ad02db100e09cac36a5465149e2924a035ee60d6c60c38fe 
INFO[0000] Built cross stage deps: map[]                
INFO[0000] Error while retrieving image from cache: getting file info: stat /cache/sha256:38236c068c393272ad02db100e09cac36a5465149e2924a035ee60d6c60c38fe: no such file or directory 
INFO[0000] Downloading base image debian@sha256:38236c068c393272ad02db100e09cac36a5465149e2924a035ee60d6c60c38fe 
INFO[0000] Unpacking rootfs as cmd RUN mkdir -p /var/test     && mkdir -p /etc/test     && touch /var/test/testfile     && touch /etc/test/testfile     && ls -lah /var/test     && ls -lah /etc/test; requires it. 
INFO[0019] Taking snapshot of full filesystem...        
INFO[0053] RUN mkdir -p /var/test     && mkdir -p /etc/test     && touch /var/test/testfile     && touch /etc/test/testfile     && ls -lah /var/test     && ls -lah /etc/test; 
INFO[0053] cmd: /bin/sh                                 
INFO[0053] args: [-c mkdir -p /var/test     && mkdir -p /etc/test     && touch /var/test/testfile     && touch /etc/test/testfile     && ls -lah /var/test     && ls -lah /etc/test;] 
total 8.0K
drwxr-xr-x  2 root root 4.0K Sep 17 17:50 .
drwxr-xr-x 12 root root 4.0K Sep 17 17:50 ..
-rw-r--r--  1 root root    0 Sep 17 17:50 testfile
total 8.0K
drwxr-xr-x 2 root root 4.0K Sep 17 17:50 .
drwxr-xr-x 1 root root 4.0K Sep 17 17:50 ..
-rw-r--r-- 1 root root    0 Sep 17 17:50 testfile
INFO[0053] Taking snapshot of full filesystem...        
error pushing image: failed to push to destination gcr.io/kaniko-test/kaniko-dockerfile_test_whitelist:latest: UNKNOWN: Unable to write upload.
exit status 1
FAIL	github.com/GoogleContainerTools/kaniko/integration	356.172s


[ID: 5997453] Build finished after 443 secs, exit value: 1

[N4rm0]

@tejal29 I am not sure what cause the issue with the integration test, as I ran them without encountering the error mentioned in your log.
I took the liberty of adding a test case in the integration test for ADD.

Could you relaunch the integration tests ?

[tejal29]

re-launching the tests.