Fix kaniko caching

[discordianfish]

Three changes to help with the caching:

• Had to revert Change cache key calculation to be more reproducible. #525, see Regression: #525 causes missing files when caching is enabled in some situations #631
• Add back debug logging of cache key, I think this is useful
• Remove build args in cache key, This should be save, given that the commands will have the args included when the cache key gets built.

[dlorenc]

Sorry for the delay!

[orf]

We might be experiencing an issue relating to this: #690

Remove build args in cache key, This should be save, given that the commands will have the args included when the cache key gets built.

Are you sure this is correct? It seems from what I am seeing that it is indeed not safe.

[discordianfish]

@orf I'm not sure - I just thought it would be save given that the build arg modifies the hash of the command. But I haven't found a obvious way to verify it. I hoped I'd get input from the maintainers to discuss that.

[orf]

I’m quite concerned a new release went out with this. @priyawadhwa did you see my issue or my comment? This seems to explicitly break caching :/

[8ear]

Is there any news?

[priyawadhwa]

Hey @8ear @orf sorry for the delay, I haven't had a whole lot of time recently to look into this. If either of you is willing to open a PR, please cc me and I can take a look at it!