Environment variables should be replaced in URLs in ADD commands. #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's one more separate fix here (this should trigger it in integration test runs) that I'll add after they fail. |
dlorenc
force-pushed
the
fixadd
branch
2 times, most recently
from
56f5805
to
97708a0
Compare
We were previously explicitly skipping this for some reason, but Docker seems to expand these in URLs so we should too.
imjasonh
reviewed
Feb 25, 2019
imjasonh
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously explicitly skipping this for some reason, but Docker
seems to expand these in URLs so we should too.