Added a KanikoStage type for each stage of a Dockerfile #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2018 14:15
I added a KanikoStage to hold each stage of the Dockerfile along with information about each stage that would be useful later on. The new KanikoStage type holds the stage itself, along with some additional information: 1. FinalStage -- whether the current stage is the final stage 2. BaseImageStoredLocally/BaseImageIndex -- whether the base image for this stage is stored locally, and if so what the index of the base image is 3. SaveStage -- whether this stage needs to be saved for use in a future stage This is the first part of a larger refactor for building stages, which will later make it easier to add layer caching.
|
Looks like this needs a rebase |
|
Done |
aaron-prindle
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a KanikoStage to hold each stage of the Dockerfile along with
information about each stage that would be useful later on.
The new KanikoStage type holds the stage itself, along with some
additional information:
this stage is stored locally, and if so what the index of the base image
is
stage
This is the first part of a larger refactor for building stages, which
will later make it easier to add layer caching. (#300)