Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --target flag for multistage builds #255

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

priyawadhwa
Copy link
Collaborator

Should fix #253

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@@ -40,6 +42,15 @@ func Parse(b []byte) ([]instructions.Stage, error) {
return stages, err
}

func Validate(stages []instructions.Stage, target string) error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this makes it sound like you're going to validate the whole Dockerfile, when all we're really checking is that the target exists. Maybe rename it to that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@priyawadhwa priyawadhwa merged commit cac00b9 into GoogleContainerTools:master Jul 30, 2018
@priyawadhwa priyawadhwa deleted the target branch July 30, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to save save/upload stage/built targets.
3 participants