Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiling for Snapshotting errors. #1530

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Profiling for Snapshotting errors. #1530

merged 2 commits into from
Dec 22, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Dec 21, 2020 •
edited
Loading

In this PR,

  1. Update GowalkDir dependency to pick up fixes.
  2. Added default 90 min timeout for walking FS which can be overridden by environment variable.
  3. Add slowjam to kaniko pod

Integrating slowjam with Kaniko was a quick fix.

  1. There is no change in the size of kaniko binary.
  2. The only dependency vendored in is "vendor/github.com/google/slowjam/pkg/stacklog/stacklog.go"
    I don't expect the kaniko image size to increase too. - pending verification.

TODO:

  1. Review the instruction in ReadMe.

@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Dec 21, 2020
@tejal29
Update GowalkDir dependency to pick up fixes. Added default 90 min ti…
f83de01 
…meout for walking FS. Override it with environment variable. Add slowjam to kaniko pod
medyagh
medyagh approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tejal29 tejal29 merged commit 9f76932 into GoogleContainerTools:master Dec 22, 2020
@tejal29
Copy link
Member Author

tejal29 commented Dec 22, 2020

Generated slowjam analysis
image

@tejal29 tejal29 deleted the add_timeout_snapshotting branch April 26, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

Assignees
No one assigned
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tejal29 @medyagh