Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix use new run marker #1379

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Aug 12, 2020

Fixes #1317, #1316

usually, during Run command temporary files get created and then get deleted later.
During that time, walk might encounter such a file and os.Stat may return err which would abort to the whole filesystem walk. due to this, Run command changed files is incomplete.
Instead of erroring out, print a warning to the user.

update-alternatives: using /usr/share/postgresql/11/man/man1/psql.1.gz to provide /usr/share/man/man1/psql.1.gz (psql.1.gz) in auto mode
Setting up postgresql-client (11+200+deb10u3) ...
Processing triggers for libc-bin (2.28-10) ...
WARN[0160] error retrieving stat for file /etc/alternatives/pager.1.gz: stat /etc/alternatives/pager.1.gz: no such file or directory 
WARN[0160] error retrieving stat for file /etc/alternatives/rmt.8.gz: stat /etc/alternatives/rmt.8.gz: no such file or directory 
WARN[0160] error retrieving stat for file /etc/alternatives/awk.1.gz: stat /etc/alternatives/awk.1.gz: no such file or directory 
WARN[0160] error retrieving stat for file /etc/alternatives/nawk.1.gz: stat /etc/alternatives/nawk.1.gz: no such file or directory 
WARN[0160] error retrieving stat for file /etc/alternatives/builtins.7.gz: stat /etc/alternatives/builtins.7.gz: no such file or directory 
INFO[0160] Taking snapshot of files...   

@tejal29 tejal29 merged commit 4ec9f20 into GoogleContainerTools:master Aug 13, 2020
@tejal29 tejal29 deleted the fix_use_new_run branch April 26, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with --use-new-run=true generates an incomplete image
2 participants