Update docker-credential-gcr to support auth with GCP Artifact Registry #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrissng
changed the title
|
Are there any updates on merging this please? |
tejal29
approved these changes
May 19, 2020
Sorry for the delay. Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1256
Description
This PR updates the docker-credential-gcr helper to the latest version (v2.0.1) which supports GCP's Artifact Registry.
Although the changelogs in docker-credential-gcr did not explicitly specify support for Artifact Registry, I suspect a vendor module update between v1.5 and v2.0 added support for it.
Also according to Artifact Registry's docs on auth setup, it indicated to use the 2.0 version if using standalone helper.
Release Notes