Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle MAINTAINERS when passing --single-snapshot. #1192

Merged
merged 1 commit into from
May 4, 2020
Merged

Handle MAINTAINERS when passing --single-snapshot. #1192

merged 1 commit into from
May 4, 2020

Conversation

tomprince
Copy link
Contributor

@tomprince tomprince commented Apr 13, 2020 •
edited
Loading

Fixes #1150.

Submitter Checklist

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

- Handle `MAINTAINERS` when passing `--single-snapshot`.

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Apr 13, 2020
@tomprince tomprince force-pushed the snapshot-maintainers branch 3 times, most recently from 8dca848 to 484d035 Compare April 13, 2020 23:40
@tejal29
Copy link
Member

tejal29 commented May 4, 2020

Thanks for the diagnosis and a PR @tomprince!

@tejal29 tejal29 merged commit a2af327 into GoogleContainerTools:master May 4, 2020
@tomprince tomprince deleted the snapshot-maintainers branch May 4, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

Assignees
No one assigned
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--single-snapshot fails if there is a MAINTAINER command in the dockerfile
3 participants
@tomprince @tejal29 @googlebot