Add secondary group impersonation w/ !cgo support #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
reviewed
Apr 14, 2020
|
Regarding integration tests, all the integration tests pass. Did you mean, you need to add new intergration test? You could add the dockerfile mentioned in the issue to
|
tejal29
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: PR is a bit funky so as to support !cgo builds, such as what we use in the Kaniko image.
Without cgo, Go is not able to use getgroups() to resolve group information. This PR falls back to parsing /etc/group with the same logic as what is used in Go's source tree, but adds secondary group information.
Integration tests will require some hand-holding.
Fixes #1097