Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that this tool is not officially supported by Google #1044

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

tstromberg
Copy link
Contributor

This is in-line with what I will be doing with our other GoogleContainerTools projects. Thoughts?

Fixes #<issue number>. in case of a bug fix, this should point to a bug and any other related issue(s)

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- Skaffold config changes like
  e.g. "Add buildArgs to `Kustomize` deployer skaffold config."
- Bug fixes
  e.g. "Improve skaffold init behaviour when tags are used in manifests"
- Any changes in skaffold behavior
  e.g. "Artiface cachine is turned on by default."

This is in-line with what I will be doing with our other GoogleContainerTools projects. Thoughts?
@googlebot googlebot added the cla: yes CLA signed by all commit authors label Feb 11, 2020
@tstromberg tstromberg changed the title Document that Kaniko is not officially supported Document that Kaniko is not officially supported by Google Feb 11, 2020
@tstromberg tstromberg changed the title Document that Kaniko is not officially supported by Google Document that this tool is not officially supported by Google Feb 11, 2020
@tejal29 tejal29 merged commit 2ab146d into master Feb 13, 2020
@tejal29 tejal29 deleted the tstromberg-patch-1 branch April 26, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants