Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example pod.yml to not mount to root #1043

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

jsravn
Copy link
Contributor

@jsravn jsravn commented Feb 10, 2020

As mounting to root makes /root a read only filesystem, which breaks a lot of builds that try to add files to /root (like /root/.npm).

Fixes #495.

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- Skaffold config changes like
  e.g. "Add buildArgs to `Kustomize` deployer skaffold config."
- Bug fixes
  e.g. "Improve skaffold init behaviour when tags are used in manifests"
- Any changes in skaffold behavior
  e.g. "Artiface cachine is turned on by default."

As mounting to root makes `/root` a read only filesystem, which breaks a lot of builds that try to add files to `/root` (like `/root/.npm`).
@googlebot googlebot added the cla: yes CLA signed by all commit authors label Feb 10, 2020
@jsravn
Copy link
Contributor Author

jsravn commented Feb 10, 2020

Is /kaniko/.docker the canonical choice over /root/.docker? Both seem to work.

@tejal29
Copy link
Member

tejal29 commented Feb 12, 2020

/kaniko/.docker the

@jsravn /root/.docker would work if your build is not adding files to /root which is the case in your build.

@tejal29 tejal29 merged commit 1e9f525 into GoogleContainerTools:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kaniko build failing on Kubernetes with simple node project calling npm install
3 participants