Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, refactor, chore(egen): adds endpoint.wait() to fix timeout error, hardcodes TF to 2.15.1, adds code in cleanup section to delete locally generated files, refactors code as per template guidelides, performs linter test #3252

Conversation

sumanvita-springml
Copy link
Contributor

This PR included the following changes:

  1. Hardcodes TF version to 2.15.1
  2. Adds endpoint.wait() to fix timeout error while deploying model to endpoint
  3. Adds code to delete locally generated files
  4. Deletes function to generate UUID and replaces UUID with unique
  5. Changes REGION to LOCATION
  6. Changes aip to aiplatform
  7. Removes function that generates UUID and replaces UUID with unique
  8. Includes Colab restart kernal and authentication as per template guidelines
  9. Adds collab enterprise logo
  10. Makes structural changes according to the new notebook template
  11. Removes the use of future tense
  12. Contracts words like it is to it's and do not to don't etc

REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

…, hardcodes TF to 2.15.1, adds code in cleanup section to delete locally generated files, refactors code as per template guidelides, performs linter test
@sumanvita-springml sumanvita-springml requested a review from a team as a code owner July 11, 2024 11:26
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@kittyabs kittyabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits, with one involving a URL (to avoid a redirect)

@katiemn
Copy link
Collaborator

katiemn commented Jul 11, 2024

/gcbrun

@katiemn
Copy link
Collaborator

katiemn commented Jul 12, 2024

/gcbrun

@katiemn katiemn added this pull request to the merge queue Jul 12, 2024
Merged via the queue into GoogleCloudPlatform:main with commit 8f2d26a Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants