Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DirectPredict, DirectRawPredict, StreamDirectRawPredict, and StreamRawPredict examples #3244

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: DirectPredict, DirectRawPredict, StreamDirectRawPredict, and StreamRawPredict examples #3244

wants to merge 12 commits into from

Conversation

michaelmoynihan
Copy link
Collaborator

@michaelmoynihan michaelmoynihan commented Jul 10, 2024 •
edited
Loading

…reamRawPredict examples.

REQUIRED: Add a summary of your PR here, typically including why the change is needed and what was changed. Include any design alternatives for discussion purposes.


feat: DirectPredict, DirectRawPredict, StreamDirectRawPredict, and StreamRawPredict examples.


REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

  1. If you are opening a PR for Community Notebooks under the notebooks/community folder:
  • This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

  1. If you are opening a PR for Community Content under the community-content folder:
  • Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
  • The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

@michaelmoynihan michaelmoynihan requested a review from a team as a code owner July 10, 2024 17:20
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@gericdong
Copy link
Contributor

/gcbrun

gericdong
gericdong reviewed Jul 10, 2024
View reviewed changes
notebooks/official/prediction/get_started_with_direct_predict.ipynb
@@ -0,0 +1,481 @@
{
Copy link
Contributor

@gericdong gericdong Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all of the outputs.


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

notebooks/official/prediction/get_started_with_direct_predict.ipynb
@@ -0,0 +1,481 @@
{
Copy link
Contributor

@gericdong gericdong Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct "Do to the requirements to provision the resource, this may take upto a few minutes."?


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is correct.

notebooks/official/prediction/get_started_with_direct_raw_predict.ipynb
@@ -0,0 +1,493 @@
{
Copy link
Contributor

@gericdong gericdong Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clear all output.


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

notebooks/official/prediction/get_started_with_direct_raw_predict.ipynb
@@ -0,0 +1,493 @@
{
Copy link
Contributor

@gericdong gericdong Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct "Do to the requirements ..."?


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is correct.

@gericdong
Copy link
Contributor

@michaelmoynihan: There are permissions issue with GCS directory "gs://grpc-predict-data/". Please check.

@michaelmoynihan
Update get_started_with_direct_predict.ipynb
cd431e3 
Removing outputs for direct predict.
@michaelmoynihan
Update get_started_with_direct_raw_predict.ipynb
21a760f 
Removing outputs for direct raw predict.
@gericdong
Copy link
Contributor

/gcbrun

@michaelmoynihan
Copy link
Collaborator Author

@michaelmoynihan: There are permissions issue with GCS directory "gs://grpc-predict-data/". Please check.

Is there a public project where I should put this?

@gericdong
Copy link
Contributor

/gcbrun

@gericdong
Copy link
Contributor

/gcbrun

@gericdong
Copy link
Contributor

@michaelmoynihan : can you please check the test failures? Let me know if you need help. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gericdong gericdong gericdong left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelmoynihan @gericdong