refactor, chore(egen): Replaces K80 GPU with T4, package version updates, pre-built Docker container image for prediction update, other corrections from template #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pgrades, updates prebuilt docker container image to 2.13, refactores notebook according to the template
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kittyabs
reviewed
Jul 10, 2024
| @@ -631,11 +598,11 @@ | |||
| "\n", | |||
| "The files `setup.cfg` and `setup.py` are the instructions for installing the package into the operating environment of the Docker image.\n", | |||
| "\n", | |||
| "The file `trainer/task.py` is the Python script for executing the custom tuning job. *Note*, when we referred to it in the worker pool specification, we replace the directory slash with a dot (`trainer.task`) and dropped the file suffix (`.py`).\n", | |||
| "The file `trainer/task.py` is the Python script for executing the custom tuning job. *Note*, when referred to it in the worker pool specification, you replace the directory slash with a dot (`trainer.task`) and dropped the file suffix (`.py`).\n", | |||
There was a problem hiding this comment.
- Shouldn't this: "Note, when referred to it in the worker pool specification, you replace the directory slash with a dot (
trainer.task) and dropped the file suffix (.py)," - be: "Note*: When
trainer/task.pyis referred to in the worker pool specification, the directory slash is replaced with a dot and the file suffix (.py) is dropped (trainer.task)."
| }, | ||
| "source": [ | ||
| "Next, build the container." | ||
| "Then, build the container and push it to Artifact Registry by running the following:" |
There was a problem hiding this comment.
Should: "build the container and push it to Artifact Registry by running the following"
Be: "build the container and push it to an Artifact Registry repository by running the following". ??
|
/gcbrun |
…pgrades, updates prebuilt docker container image to 2.13, refactores notebook according to the template
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
Please address @kittyabs suggested edits |
|
/gcbrun |
katiemn
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of the following updates:
REQUIRED: Fill out the below checklists or remove if irrelevant
Official Notebooksunder the notebooks/official folder, follow this mandatory checklist:Official Notebookssection, pointing to the author or the author's team.