-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor, chore(egen): Replaces K80 GPU with T4, package version updates, pre-built Docker container image for prediction update, other corrections from template #3241
Conversation
…pgrades, updates prebuilt docker container image to 2.13, refactores notebook according to the template
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggested edits
@@ -631,11 +598,11 @@ | |||
"\n", | |||
"The files `setup.cfg` and `setup.py` are the instructions for installing the package into the operating environment of the Docker image.\n", | |||
"\n", | |||
"The file `trainer/task.py` is the Python script for executing the custom tuning job. *Note*, when we referred to it in the worker pool specification, we replace the directory slash with a dot (`trainer.task`) and dropped the file suffix (`.py`).\n", | |||
"The file `trainer/task.py` is the Python script for executing the custom tuning job. *Note*, when referred to it in the worker pool specification, you replace the directory slash with a dot (`trainer.task`) and dropped the file suffix (`.py`).\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Shouldn't this: "Note, when referred to it in the worker pool specification, you replace the directory slash with a dot (
trainer.task
) and dropped the file suffix (.py
)," - be: "Note*: When
trainer/task.py
is referred to in the worker pool specification, the directory slash is replaced with a dot and the file suffix (.py
) is dropped (trainer.task
)."
}, | ||
"source": [ | ||
"Next, build the container." | ||
"Then, build the container and push it to Artifact Registry by running the following:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should: "build the container and push it to Artifact Registry by running the following"
Be: "build the container and push it to an Artifact Registry repository by running the following". ??
/gcbrun |
…pgrades, updates prebuilt docker container image to 2.13, refactores notebook according to the template
/gcbrun |
/gcbrun |
/gcbrun |
Please address @kittyabs suggested edits |
/gcbrun |
This PR consists of the following updates:
REQUIRED: Fill out the below checklists or remove if irrelevant
Official Notebooks
under the notebooks/official folder, follow this mandatory checklist:Official Notebooks
section, pointing to the author or the author's team.