Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore,refaactor(egen): minor changes to sdk feature store pandas notebook #3239

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

sriramya2610
Copy link
Contributor

This PR includes the following updates:

  1. Adds Colab Enterprise link and other structural changes from the new template.
  2. Changes REGION variable name to LOCATION.
  3. Removed os.getenv("IS_TESTING") while cleanup bucket.
  4. Adds comments for cells needed.

REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

sriramya2610 added 2 commits July 10, 2024 09:46
…ed os.getenv(IS_TESTING) while cleanup bucket, refactored code according to the template and performed linter test
…ed os.getenv(IS_TESTING) while cleanup bucket, refactored code according to the template and performed linter test
@sriramya2610 sriramya2610 requested a review from a team as a code owner July 10, 2024 09:58
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@kittyabs kittyabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no edits required

@katiemn
Copy link
Collaborator

katiemn commented Jul 10, 2024

/gcbrun

@katiemn katiemn added this pull request to the merge queue Jul 10, 2024
Merged via the queue into GoogleCloudPlatform:main with commit fd15c01 Jul 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants