Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore, fix(egen): follows new template, markdown updates and fixes #3221

Merged

Conversation

krishr2d2
Copy link
Contributor


This PR includes the following updates to the `challenger_vs_blessed_deployment_method.ipynb` notebook:
  • Change REGION to LOCATION
  • Remove IS_TESTING condition at cleaning step
  • Adds IS_COLAB in the service account setup
  • Removes USER in the installation
  • Moves the deletion of local files to the cleaning up section
  • Add Colab Enterprise link and other updates from new template.
  • Reorganizes the heading styles to match the steps.
  • Removes unnecessary code highlights
  • Removes future tense
  • Contracts words like "do not" --> "don't"
  • Update K80 GPU with T4 GPU




REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

krishr2d2 added 2 commits July 6, 2024 13:23
…OCATION, organizes headings and styles, removes unnecessary code highlights
@krishr2d2 krishr2d2 requested a review from a team as a code owner July 6, 2024 14:49
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gericdong
Copy link
Contributor

/gcbrun

Copy link
Collaborator

@kittyabs kittyabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numerous edits

@katiemn
Copy link
Collaborator

katiemn commented Jul 10, 2024

/gcbrun

@katiemn katiemn added this pull request to the merge queue Jul 10, 2024
Merged via the queue into GoogleCloudPlatform:main with commit 650272e Jul 10, 2024
6 checks passed
@krishr2d2 krishr2d2 deleted the challenger_vs_blessed_deploy branch July 11, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants