Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(egen): follows new template, fixes typos, K80-->T4, REGION-->LOCATION etc. #3214

Conversation

krishr2d2
Copy link
Contributor


This PR makes the following updates to the `multicontender_vs_champion_deloyment_method.ipynb` notebook:
  • Change REGION to LOCATION
  • Remove IS_TESTING condition at cleaning step
  • Add Colab enterprise link
  • Add Colab specific steps and other updates according to the new notebook template
  • Remove future tense
  • Contract words (like do not --> don't etc.)
  • Fix the position of a sub-section (for "Save the model artifacts")
  • Replace K80 with T4 in the text about GPUs
  • Fix the typo "modesl"
  • Moves the clean up step for yaml file to the last section
  • Removes unnecessary code highlights (using "``")
  • Handles the cases for Vertex AI resources



REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

…ghlights, replaces K80 with T4, replaces REGION with LOCATION, removes IS_TESTING in cleaning up section, makes sentence/heading corrections and re-organizes some subsections as per the tutorial
@krishr2d2 krishr2d2 requested a review from a team as a code owner July 4, 2024 18:10
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gericdong
Copy link
Contributor

/gcbrun

@gericdong
Copy link
Contributor

/gcbrun

…AI model resource' to 'uploading to Vertex AI Model Registry'
Copy link
Collaborator

@kittyabs kittyabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggested edits

@katiemn
Copy link
Collaborator

katiemn commented Jul 11, 2024

/gcbrun

@katiemn katiemn added this pull request to the merge queue Jul 12, 2024
Merged via the queue into GoogleCloudPlatform:main with commit 0f01fd7 Jul 12, 2024
6 checks passed
@krishr2d2 krishr2d2 deleted the multicontender_vs_champion_deployment branch July 12, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants