Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore, fix, refactor(egen): minor updates to custom model training and batch prediction notebook #3213

Conversation

krishr2d2
Copy link
Contributor


This PR consists of the following updates to the `custom_model_training_and_batch_prediction.ipynb` notebook:
  • Changed REGION variable name to LOCATION.
  • Replaced aip with aiplatform.
  • Replaced K80 GPU with T4 GPU (as K80 is deprecated).
  • Replaced version 2-5 with version 2-13 in both training and deployment images and and also changed the path of images.
  • Replaced base_image tensorflow latest version with tensorflow 2.13.0 version in the component
  • Added .keras extension when saving and uploading the model.
  • Replaced imageuri 2-3 version with 2-13 version in import model step in pipeline and also changed the path of imageuri.
  • Removed IS_TESTING from the cleaning up section.
  • Removed import statement of os module.
  • Added colab enterprise logo with link
  • Heading changes according to template guidelines
  • Added comments for cells needed.



REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

…th T4 GPU, changed the versions of images,.keras extension added when saving and uploading the model, removed import statement of os module, refactored code according to template guidelines and performed linter test.
@krishr2d2 krishr2d2 requested a review from a team as a code owner July 4, 2024 14:09
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gericdong
Copy link
Contributor

/gcbrun

@katiemn katiemn added this pull request to the merge queue Jul 9, 2024
Merged via the queue into GoogleCloudPlatform:main with commit 2e330ab Jul 9, 2024
6 checks passed
@krishr2d2 krishr2d2 deleted the custom_model_train_and_batch_pred branch July 9, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants