-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fetch historical feature values notebook #3184
feat: add fetch historical feature values notebook #3184
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
574bb80
to
cd55233
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a few edits. Overall, it looks good. The code blocks should ideally have descriptions associated with them.
...oks/official/feature_store/offline_feature_serving_from_bigquery_with_feature_registry.ipynb
Outdated
Show resolved
Hide resolved
...oks/official/feature_store/offline_feature_serving_from_bigquery_with_feature_registry.ipynb
Outdated
Show resolved
Hide resolved
...oks/official/feature_store/offline_feature_serving_from_bigquery_with_feature_registry.ipynb
Outdated
Show resolved
Hide resolved
...oks/official/feature_store/offline_feature_serving_from_bigquery_with_feature_registry.ipynb
Show resolved
Hide resolved
...oks/official/feature_store/offline_feature_serving_from_bigquery_with_feature_registry.ipynb
Show resolved
Hide resolved
...oks/official/feature_store/offline_feature_serving_from_bigquery_with_feature_registry.ipynb
Show resolved
Hide resolved
...oks/official/feature_store/offline_feature_serving_from_bigquery_with_feature_registry.ipynb
Outdated
Show resolved
Hide resolved
...oks/official/feature_store/offline_feature_serving_from_bigquery_with_feature_registry.ipynb
Show resolved
Hide resolved
...oks/official/feature_store/offline_feature_serving_from_bigquery_with_feature_registry.ipynb
Show resolved
Hide resolved
...oks/official/feature_store/offline_feature_serving_from_bigquery_with_feature_registry.ipynb
Outdated
Show resolved
Hide resolved
84fa820
to
cf7bd37
Compare
@mrkumar9001: please let me know if this PR is ready. Thanks. |
cf7bd37
to
9f6a66f
Compare
REQUIRED: Add a summary of your PR here, typically including why the change is needed and what was changed. Include any design alternatives for discussion purposes.
feat: add fetch historical feature values notebook
REQUIRED: Fill out the below checklists or remove if irrelevant
Official Notebooks
under the notebooks/official folder, follow this mandatory checklist:Official Notebooks
section, pointing to the author or the author's team.Community Notebooks
under the notebooks/community folder:Community Notebooks
section, pointing to the author or the author's team.Community Content
under the community-content folder:Content Directory Name
is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other contentCommunity Content
section, pointing to the author or the author's team.