Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore, refactor(egen): format and refactor for get_started_with_model_monitoring_custom_tf_serving notebook #3162

Merged
merged 6 commits into from
Jul 5, 2024
Merged

chore, refactor(egen): format and refactor for get_started_with_model_monitoring_custom_tf_serving notebook #3162

merged 6 commits into from
Jul 5, 2024

Conversation

k-root
Copy link
Contributor

@k-root k-root commented Jun 27, 2024

Following changes are made as part of the PR:

  • REGION updated to LOCATION
  • Removes boilerplate
  • Formats according to template

REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

  1. If you are opening a PR for Community Notebooks under the notebooks/community folder:
  • This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

  1. If you are opening a PR for Community Content under the community-content folder:
  • Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
  • The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
  • Passes all the required formatting and linting checks. You can locally test with these instructions.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@k-root k-root marked this pull request as ready for review June 27, 2024 15:08
@k-root k-root requested a review from a team as a code owner June 27, 2024 15:08
kittyabs
kittyabs reviewed Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@kittyabs kittyabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested edits

notebooks/official/model_monitoring/get_started_with_model_monitoring_custom_tf_serving.ipynb Outdated Show resolved Hide resolved
notebooks/official/model_monitoring/get_started_with_model_monitoring_custom_tf_serving.ipynb Outdated Show resolved Hide resolved
notebooks/official/model_monitoring/get_started_with_model_monitoring_custom_tf_serving.ipynb Outdated Show resolved Hide resolved
notebooks/official/model_monitoring/get_started_with_model_monitoring_custom_tf_serving.ipynb Outdated Show resolved Hide resolved
notebooks/official/model_monitoring/get_started_with_model_monitoring_custom_tf_serving.ipynb Outdated
@@ -754,12 +705,12 @@
"\n",
"The following are the basic steps to enable model monitoring:\n",
"\n",
"1. Deploy a `Vertex AI` AutoML or custom tabular model to an `Vertex AI Endpoint`.\n",
"1. Deploy a Vertex AI AutoML or custom tabular model to an Vertex AI Endpoint.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lower case: "Vertex AI endpoint"

notebooks/official/model_monitoring/get_started_with_model_monitoring_custom_tf_serving.ipynb Outdated Show resolved Hide resolved
notebooks/official/model_monitoring/get_started_with_model_monitoring_custom_tf_serving.ipynb Outdated
@@ -1197,7 +1148,7 @@
"- `display_name`: The human readable name for the monitoring job.\n",
"- `project`: The project ID.\n",
"- `region`: The region.\n",
"- `endpoint`: The fully qualified resource name of the `Vertex AI Endpoint` to enable monitoring.\n",
"- `endpoint`: The fully qualified resource name of the Vertex AI Endpoint to enable monitoring.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lower case: "Vertex AI endpoint resource"

notebooks/official/model_monitoring/get_started_with_model_monitoring_custom_tf_serving.ipynb Outdated Show resolved Hide resolved
notebooks/official/model_monitoring/get_started_with_model_monitoring_custom_tf_serving.ipynb Outdated Show resolved Hide resolved
notebooks/official/model_monitoring/get_started_with_model_monitoring_custom_tf_serving.ipynb Outdated Show resolved Hide resolved
@gericdong
Copy link
Contributor

/gcbrun

@gericdong
Copy link
Contributor

/gcbrun

@k-root
Copy link
Contributor Author

k-root commented Jul 4, 2024

Addressed all comments. Please review

@gericdong
Copy link
Contributor

/gcbrun

@gericdong gericdong added this pull request to the merge queue Jul 5, 2024
Merged via the queue into GoogleCloudPlatform:main with commit 24ff289 Jul 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittyabs kittyabs kittyabs left review comments

@gericdong gericdong gericdong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k-root @gericdong @kittyabs