Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bigquery): prefer env var to arguments #1777

Merged
merged 5 commits into from
Feb 21, 2023
Merged

chore(bigquery): prefer env var to arguments #1777

merged 5 commits into from
Feb 21, 2023

Conversation

vishwarajanand
Copy link
Member

@vishwarajanand vishwarajanand commented Feb 14, 2023 •
edited
Loading

Relevant cgc website
Relevant region tag

Change

  1. Remove the use of env var GOOGLE_CLOUD_PROJECT or command line args for running bigquery/stackoverflow/stackoverflow.php.
  2. Relevant changes in test.

Tests

  1. Tests are passing in php74.
bigquery/stackoverflow % ../../testing/vendor/bin/phpunit -c phpunit.xml.dist            (git)-[chore_show_click_to_copy_code]-
PHPUnit 8.5.26 #StandWithUkraine

Error:         XDEBUG_MODE=coverage or xdebug.mode=coverage has to be set

.                                                                   1 / 1 (100%)

Time: 1.82 seconds, Memory: 8.00 MB

OK (1 test, 1 assertion)
bigquery/stackoverflow %
  1. Tested that this samples executes without errors in cloudshell env:

Screenshot 2023-02-21 at 12 24 17

In continuation with: #1776

@product-auto-label product-auto-label bot added api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples. labels Feb 14, 2023
@vishwarajanand
Copy link
Member Author

CC: @chellebodnar-google

@vishwarajanand
Copy link
Member Author

vishwarajanand commented Feb 14, 2023 •
edited
Loading

Confirmed that the lint failure is unrelated to the changes in this PR.

@vishwarajanand vishwarajanand marked this pull request as ready for review February 14, 2023 07:14
@vishwarajanand vishwarajanand requested a review from a team as a code owner February 14, 2023 07:14
@vishwarajanand
Copy link
Member Author

lint errors are fixed in: #1780

@bshaffer bshaffer merged commit 72ff6f0 into GoogleCloudPlatform:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishwarajanand @bshaffer