feat(Bigquery): Undelete table sample.

[yash30201]

This sample showcases how to restore an accidently deleted table within the time travel window.

[snippet-bot]

Here is the summary of changes.

You are about to add 1 region tag.

• bigquery/api/src/undelete_table.php:26, tag bigquery_undelete_table

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[vishwarajanand]

A side comment, do you think adding a break after foundValue is set in verifyTable makes sense?

php-docs-samples/bigquery/api/test/bigqueryTest.php

Lines 437 to 444 in 02086fb

	foreach ($table->rows([]) as $row) {
	foreach ($row as $column => $value) {
	if ($value == $expectedValue) {
	$foundValue = true;
	}
	}
	$numRows++;
	}

[vishwarajanand]

LGTM, just fix the few remaining nits and we are good to go.

[yash30201]

A side comment, do you think adding a break after foundValue is set in verifyTable makes sense?

php-docs-samples/bigquery/api/test/bigqueryTest.php

Lines 437 to 444 in 02086fb

	foreach ($table->rows([]) as $row) {
	foreach ($row as $column => $value) {
	if ($value == $expectedValue) {
	$foundValue = true;
	}
	}
	$numRows++;
	}

@vishwarajanand, As we need to get the numRows also, so breaking would give incorrent numRows value thus the assertion would fail. Thus putting a break isn't feasible there.

[vishwarajanand]

@yash30201 I was suggesting something like below which would preserve the $numRows value:

 foreach ($table->rows([]) as $row) { 
     foreach ($row as $column => $value) { 
         if ($value == $expectedValue) { 
             $foundValue = true;  
             break;  // here
         } 
     } 
     $numRows++; 
 } 

[yash30201]

@yash30201 I was suggesting something like below which would preserve the $numRows value:

 foreach ($table->rows([]) as $row) { 
     foreach ($row as $column => $value) { 
         if ($value == $expectedValue) { 
             $foundValue = true;  
             break;  // here
         } 
     } 
     $numRows++; 
 } 

@vishwarajanand , Oh you meant breaking just the inner loop, then should we do as follows?

 foreach ($table->rows([]) as $row) { 
     if (!$foundValue) {
         foreach ($row as $column => $value) { 
             if ($value == $expectedValue) { 
                 $foundValue = true;  
                 break;  // here
             } 
         }
     } 
     $numRows++; 
 }

Because apart from matching row, all other rows would be traversed completely in your code suggestion and thus putting a single break won't make much performance difference.

[vishwarajanand]

LGTM