Add auth support for gRPC #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
reviewed
Apr 11, 2024
| } else if (exporter instanceof OtlpGrpcSpanExporter) { | ||
| try { | ||
| credentials.refreshIfExpired(); | ||
| OtlpGrpcSpanExporterBuilder builder = |
There was a problem hiding this comment.
Do we have the ability to directly pass a credentials option? https://github.com/grpc/grpc-java/blob/34e241a60e7dd54195daaec3a16decae0dd702cc/api/src/main/java/io/grpc/CallOptions.java#L137
It might be nice to open an issue upstream if that isn't possible today
There was a problem hiding this comment.
I think gRPC's concept of CallOptions is not exposed to the end user in OTel Java's OTLP exporters.
That being said, I think closest analog to WithCallCredentials is the concept of an Authenticator which can be applied to both OTLPGrpcExporter and OTLPHttpExporter.
However this class is in the internal (experimental) package currently.
There was a problem hiding this comment.
Cool. It might be worth opening an issue upstream to see if they can accept CallCredentials in some form.
dashpole
reviewed
Apr 11, 2024
...lptrace/src/main/java/com/google/cloud/opentelemetry/example/otlptrace/OTLPTraceExample.java
Show resolved
Hide resolved
dashpole
reviewed
Apr 11, 2024
...lptrace/src/main/java/com/google/cloud/opentelemetry/example/otlptrace/OTLPTraceExample.java
Show resolved
Hide resolved
dashpole
approved these changes
Apr 11, 2024
…y/example/otlptrace/OTLPTraceExample.java Co-authored-by: David Ashpole <dashpole@google.com>
diegomarquezp
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
May 31, 2024
…rces-support to v0.29.0 (#2831) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud.opentelemetry:detector-resources-support](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java) | `0.28.0` -> `0.29.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>GoogleCloudPlatform/opentelemetry-operations-java (com.google.cloud.opentelemetry:detector-resources-support)</summary> ### [`v0.29.0`](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/releases/tag/v0.29.0) [Compare Source](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/compare/v0.28.0...v0.29.0) #### Release Highlights - Non-GKE resource now map to `k8s_*` monitored resource ([#​340](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/issues/340) , [#​342](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/issues/342)) - Support for mapping to custom Monitored Resources ([#​346](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/issues/346)) - Newly deprecated APIs: [mapResource](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/blob/b0caafdaceb2b7418d256cecc05fa8fce9bafecc/exporters/metrics/src/main/java/com/google/cloud/opentelemetry/metric/ResourceTranslator.java#L36) #### What's Changed - Update maven-badges to link to sonatype central by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#322 - Add auth support for gRPC by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#323 - Switch to ConcurrentMap for thread-safety by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#328 - Add otlp with spring boot sample by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#327 - Change OTel quickstart to use log4j2 instead of logback by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#330 - Always output logging.googleapis.com/trace_sampled as true by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#332 - Update JVM flag otel.java.experimental.extension by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#338 - Add test case for zone resource detection on GAE standard by [@​aabmass](https://togithub.com/aabmass) in [GoogleCloudPlatform/opentelemetry-operations-java#341 - Fix [#​258](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/issues/258) enable mapping when not gcp kubernetes by [@​tkmsaaaam](https://togithub.com/tkmsaaaam) in [GoogleCloudPlatform/opentelemetry-operations-java#340 - Fix [#​340](https://togithub.com/GoogleCloudPlatform/opentelemetry-operations-java/issues/340) bug by [@​tkmsaaaam](https://togithub.com/tkmsaaaam) in [GoogleCloudPlatform/opentelemetry-operations-java#342 - Make all AttributeMappings final by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#347 - Add support for custom MR mappings by [@​psx95](https://togithub.com/psx95) in [GoogleCloudPlatform/opentelemetry-operations-java#346 #### New Contributors - [@​tkmsaaaam](https://togithub.com/tkmsaaaam) made their first contribution in [GoogleCloudPlatform/opentelemetry-operations-java#340 **Full Changelog**: GoogleCloudPlatform/opentelemetry-operations-java@v0.28.0...v0.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to generate traces using gRPC as well.
Testing
gradle run