Pubsub getting started #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readme, pom.xml cleanup
…docs-samples into pubsub_getting_started
jabubake
added
the
do not merge
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #684 +/- ##
=========================================
Coverage 58.39% 58.39%
Complexity 165 165
=========================================
Files 78 78
Lines 2329 2329
Branches 160 160
=========================================
Hits 1360 1360
Misses 922 922
Partials 47 47Continue to review full report at Codecov.
|
…docs-samples into pubsub_getting_started
jabubake
removed
the
do not merge
lesv
approved these changes
Jul 31, 2017
|
|
||
| // Create a new subscription | ||
| SubscriptionName subscriptionName = SubscriptionName.create(projectId, subscriptionId); | ||
| try (SubscriptionAdminClient subscriptionAdminClient = SubscriptionAdminClient.create()) { |
There was a problem hiding this comment.
Rather than throw an exception (above), shouldn't we catch them and explain why they might get one and what to do if they do?
There was a problem hiding this comment.
Submitted googleapis/google-cloud-java#2295
|
|
||
| //schedule a message to be published, messages are automatically batched | ||
| private static ApiFuture<String> publishMessage(Publisher publisher, String message) | ||
| throws Exception { |
There was a problem hiding this comment.
Rather than throwing an exception, shouldn't we catch them? and explain what's going on?
|
Ping |
…docs-samples into pubsub_getting_started
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
…4.5 (#684) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-pubsub](https://togithub.com/googleapis/java-pubsub) | `1.114.4` -> `1.114.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-pubsub</summary> ### [`v1.114.5`](https://togithub.com/googleapis/java-pubsub/blob/master/CHANGELOG.md#​11145-httpswwwgithubcomgoogleapisjava-pubsubcomparev11144v11145-2021-09-27) [Compare Source](https://togithub.com/googleapis/java-pubsub/compare/v1.114.4...v1.114.5) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dlp).
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
](https://renovatebot.com){kind=link}
🤖 I have created a release \*beep\* \*boop\* --- ### [3.0.8](https://www.github.com/googleapis/java-dlp/compare/v3.0.7...v3.0.8) (2021-09-29) ### Dependencies * update dependency com.google.cloud:google-cloud-pubsub to v1.114.5 ([#684](https://www.github.com/googleapis/java-dlp/issues/684)) ([3a2377a](https://www.github.com/googleapis/java-dlp/commit/3a2377a4f54d5c84e023dbc08c2c40853a5f9067)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit (WIP)