Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that modified files are automatically reloaded. #8

Merged
merged 3 commits into from
Jan 30, 2020

Conversation

ilpersi
Copy link
Contributor

@ilpersi ilpersi commented Jan 22, 2020

This is a possible fix for issue #6. Adding watchdog as a dependency would make sure that, when functions-framework is run in DEBUG mode, modifications to files are reloaded.

Fixes #6.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@di di added the cla: yes label Jan 30, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@di di merged commit 62eb8c5 into GoogleCloudPlatform:master Jan 30, 2020
@di
Copy link
Member

di commented Jan 30, 2020

Thanks @ilpersi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to automatically reload modifications to main.py?
3 participants